Skip to content

Keep the discovery tests off the test machine's own network - #225

Open
AnjinMeili wants to merge 1 commit into
MoonModules:mainfrom
AnjinMeili:discovery-rfc5737
Open

AnjinMeili wants to merge 1 commit into
MoonModules:mainfrom
AnjinMeili:discovery-rfc5737

Conversation

@AnjinMeili

Copy link
Copy Markdown
Contributor

The discovery tests inject packets from 192.0.2.x, the documentation range of RFC 5737, so a test machine on 192.168.1.x no longer lists one of them as itself.

Tests

  • unit_DevicesModule_discovery: every injected and expected address moves from 192.168.1.x to 192.0.2.x, the same last octet.

Docs/CI

  • check_prose: NegatedHeading 6 to 8 and SelfReference 16 to 17 are main's baseline: the committed tree measures the same with this change absent.

Reviews

  • none

What an agent wrote: Claude Code (Opus) wrote the code, the tests and this text from my direction; I reviewed every line and vouch for it.

Tested: On this branch on macOS, all 2849 desktop tests pass. On main, the same Mac fails "distinct devices don't cross-contaminate name or type", since it holds 192.168.1.186, the address that test injects a WLED from (#224 records it). check_code ran on this branch before the push.

Skipped checks:

  • Scenarios skipped: the change is test addresses only.
  • collect_kpi skipped: no product code changes.

🤖 Generated with Claude Code

The discovery tests inject packets from 192.0.2.x, the documentation range of RFC 5737, so a test machine on 192.168.1.x no longer lists one of them as itself.

**Tests**
- unit_DevicesModule_discovery: every injected and expected address moves from 192.168.1.x to 192.0.2.x, the same last octet.
- test_desktop: 2,875 passed on macOS and the Pi 5 (whole branch).

**Docs/CI**
- check_prose: NegatedHeading 6 to 8 and SelfReference 16 to 17 are main's baseline: the committed tree measures the same with this change absent.

**Reviews**
- none

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings October 31, 2026 09:02
@coderabbitai

coderabbitai Bot commented Oct 31, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

There are no active review issues for the discovery-fixture address update.

No open issues 🎉

What changed in this PR

Moves discovery test fixtures to RFC 5737’s documentation address range, avoiding the collision with the test machine’s 192.168.1.x address reported in #224. Production behavior is unchanged.

Changes:

  • Replaces 192.168.1.x fixture addresses and expected results with 192.0.2.x, preserving each last octet.
  • Updates helper comments to explain the address range and its purpose.
File Description
test/​unit/​core/​unit_DevicesModule_discovery.cpp Updates injected packets, restored fixtures, lookup expectations, and comments to use documentation-range addresses.

Review effort: Balanced

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants