Repository navigation
fix(server): support Unicode download filenames - #4563
Open
kimi-agent-bot wants to merge 1 commit into
Open
kimi-agent-bot wants to merge 1 commit into
kimi-agent-bot wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: f20b50d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
commit: |
Collaborator
Author
|
真实 Windows Desktop 前后验证已完成:同一会话、同一
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Requirement or Bug
修复 Desktop / Web 点击中文等非 ASCII 文件名的本地文件链接时,文件存在且可读取,但预览仍提示「无法读取这个文件」。
Bug Reproduction Steps
分析数据/stat/趋势图_20260929_20261028.png。ERR_INVALID_CHAR: Invalid character in header content ["content-disposition"],前端显示「无法读取这个文件」。Root Cause
下载路由把原始文件名直接写入
Content-Disposition的filename="..."。Node 的 HTTP header 不接受中文等非 Latin-1 字符,因此在发送响应前抛出ERR_INVALID_CHAR。这是响应头编码的根因修复,不改变文件路径解析或图片解码。Code Changes
filename*保留原始 UTF-8 文件名。Behavior Changes and Affected Users
attachment; filename="a.png"filename*受影响模块:
packages/kap-server的文件下载路由。验证:
packages/kap-server/test/fs.test.ts:66 个用例通过,包含新增中文 PNG 回归。packages/kap-servertypecheck 通过。Checklist
/approve).gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.Requested by qer via Mira.