Repository navigation
Add merchant-side Google Pay and event-specific redirect URLs - #2
Closed
hegedustibor wants to merge 5 commits into
Closed
hegedustibor wants to merge 5 commits into
hegedustibor wants to merge 5 commits into
Conversation
…vent - Add RedirectUrls for the `urls` field of payment and Request to Pay starts; SimplePay ignores the common `url` when it is sent - Add BackEvent::Pending, which Request to Pay back redirects carry while the bank transfer is under way; it used to fail with a ValueError - Accept Request to Pay start responses, which have no `timeout` - Share the signed fake response helper between test files
- Add PaymentService::doGooglePay() for the doGooglePay endpoint of the official SimplePay PHP SDK 2.1.5 (2026-06-27); a 3DS challenge (3004) returns the redirectUrl instead of throwing - Add PaymentService::googlePayConfig() and the google_pay config keys, which give the checkout page the values of the Google Pay button
- Add the Google Pay checkout guide (examples/en|hu/google-pay.md) with the backend endpoint and the JavaScript button from the official sample - Document `urls`, the Request to Pay pending event and the reuse of a failed order reference in the README, the examples and the Boost skill - Add the SVG vertical logo of the SimplePay logo pack 2026-09-21 - Update the bundled developer documentation to 2026-09-01 and add the Google Pay documentation (HU and EN)
GooglePayResponse needs transactionId and orderRef; without them the caller keeps the original SimplePayApiException, which still carries the redirectUrl.
…se sample The Boost skill showed a BackUrlResponse::toResponse() signature that does not match the contract.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mi változott
SimplePay::payment()->doGooglePay(GooglePayDoRequest): a Google Pay tokent a/v2/dogooglepayvégponton terheli. 3DS challenge-nél (3004) nem dob kivételt, hanem visszaadja aredirectUrl-t (requiresChallenge()).SimplePay::payment()->googlePayConfig(Currency, total): a fizetési oldal Google Pay gombjához szükséges értékeket adja (sandboxbanTEST, élesbenPRODUCTIONkörnyezet).SIMPLEPAY_GOOGLE_PAY_MERCHANT_IDésSIMPLEPAY_GOOGLE_PAY_MERCHANT_NAME.examples/en/google-pay.md,examples/hu/google-pay.md.urls) a fizetés és az RTP indításakor (RedirectUrls); RTP-nél apendingcímmel együtt.PENDINGeseménye eddigValueError-t dobott. Ehhez jött létre aBackEvent::Pending.timeout, ezért aPaymentResponseeddigTypeError-t dobott. Atimeoutmostantól lehetnull.orderRefújrahasználatának szabálya (a 2026.09.01-es dokumentáció pontosítása);official-docsa 2026.09.01-es fejlesztői dokumentációra frissült, és bekerült a Google Pay-leírás (magyarul és angolul).Ellenőrzés
composer testzöld PHP 8.4-en, Laravel 13.37 alatt: Larastan 0 hiba, Pint, 100%-os típuslefedettség, 89 Pest-teszt.SimplePayDoGooglePayvégpontja és mezői egyeznek;BackUrlResponse-szignatúrája;TESTkörnyezettel sem;Megjegyzések a review-hoz
PaymentResponse::$timeouttípusa?stringlett;BackEvent::Pendingeset: adefaultnélkülimatch ($back->event)kifejezéseket ki kell egészíteni (a PHPStan jelezni fogja).googlePayConfig()nem ellenőrzi, hogy be van-e állítva a Google Pay merchant ID. Ilyenkornull-t ad, és élesben csak a gomb hibázik a böngészőben.SIMPLEPAY_LOG_CHANNELbe van állítva, aClienta teljes kérést naplózza, így agooglePayToken-t is, és már eddig is az AutoPayment kártyaadatait. Ezt külön javításra javaslom.customerparaméter, és javult azRtpDoRequestpéldája.