Repository navigation
Fix documented examples that do not match the package API - #4
Merged
Merged
Conversation
- FinishRequest takes amount and originalTotal, RefundRequest takes amount - finish() takes a FinishRequest instead of named arguments - IPN events carry the message as $event->ipn; paymentMethod is a string - Complete the PaymentRequest examples of the Boost skill (total, language)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mi változott
A README, a példák és a Boost skill több kódpéldája nem a csomag valódi API-ját használta. Ezeket javítottam:
FinishRequest: a kötelezőamountésoriginalTotalbekerült a példákba. Afinish()FinishRequest-et vár; aquery-refund-cancelpéldák (angolul és magyarul) eddig nevesített argumentumokkal hívták.RefundRequest: a paraméter neveamount, nemrefundTotal.$event->ipnproperty-ben adja, nem a$event->ipnMessage-ben, és apaymentMethodstring.PaymentRequest-példáiból hiányzott a kötelezőtotaléslanguage, és ataxszámként adható meg.ErrorCodeenumban 351 kód van; a README eddig 358+-t írt.Ellenőrzés
new <Dto>(...)hívása és szolgáltatáshívása létező, kötelező paramétereket használ-e.Megjegyzések a review-hoz