You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Forward non-completion queries through affine and starts_on attrs - #2374
Forward non-completion-queries to affine and starts_on sender attributes
Forward non-completion-queries from the child sender's sender-attributes to the sender-attributes of affine and starts_on.
Fix an issue where affine's forwarding of non-completion-queries did not actually invoke the query and unnecessarily required the query result to be default-constructible.
@ericniebler
The CI failures were caused by starts_on's constrained query member template for forwarding non-completion queries not SFINAE-friendly. Its trailing return type directly uses __query_result_t, causing a hard error during instantiation of the enclosing class template when the child environment does not support the query, rather than allowing the constraint to remove the member template from the candidate set. A minimal reproducer is available on https://godbolt.org/z/xY37b5eGq.
The same pattern occurs in several other adaptors. It can be addressed either by using return type deduction to defer type instantiation or by applying a workaround like the defaulted class _Env2 = env_of_t<_Sender> parameter in
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward non-completion-queries to
affineandstarts_onsender attributesaffineandstarts_on.affine's forwarding of non-completion-queries did not actually invoke the query and unnecessarily required the query result to be default-constructible.