Repository navigation
[19.0] [IMP] queue_job: clean old jobs from the base autovacuum - #1014
Open
ivantodorovich wants to merge 1 commit into
Open
ivantodorovich wants to merge 1 commit into
ivantodorovich wants to merge 1 commit into
Conversation
Contributor
OCA-git-bot
added
series:19.0
mod:queue_job
ivantodorovich
force-pushed
the
19.0-imp-queue_job-autovacuum
branch
2 times, most recently
from
October 20, 2026 17:19
f6c2fe9 to
b843e73
Compare
ivantodorovich
commented
Oct 20, 2026
| { | ||
| "name": "Job Queue", | ||
| "version": "19.0.2.1.6", | ||
| "version": "19.0.2.2.0", |
Contributor
Author
There was a problem hiding this comment.
manual bump for the migration script
ivantodorovich
marked this pull request as ready for review
October 20, 2026 17:20
florentx
approved these changes
Oct 21, 2026
divad1196
reviewed
Oct 22, 2026
divad1196
left a comment
divad1196
left a comment
There was a problem hiding this comment.
@ivantodorovich
The PR works, but the vacuum could still be done with the ORM.
I proposed a different version that also handle a forgotten edge-case
divad1196
reviewed
Oct 22, 2026
amh-mw
approved these changes
Oct 22, 2026
amh-mw
left a comment
amh-mw
left a comment
Member
There was a problem hiding this comment.
Code review only, LGTM. Odoo 14 introduced api.autovacuum!
Neutralized databases disable every cron except the base autovacuum, so old jobs were never removed there. Replace the dedicated cron with an @api.autovacuum method, deleting in batches of 1000.
ivantodorovich
force-pushed
the
19.0-imp-queue_job-autovacuum
branch
from
October 22, 2026 16:10
b843e73 to
8ec9ef2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Neutralized databases disable every cron except the base autovacuum, so old jobs were never removed there.
Replace the dedicated cron with an @api.autovacuum method, which is the "odoo-way" of cleaning these things anyways