Repository navigation
Conversation
Contributor
amh-mw
approved these changes
Oct 21, 2026
amh-mw
left a comment
amh-mw
left a comment
Member
There was a problem hiding this comment.
Code review only, LGTM. This reminds me of workarounds I was using locally prior to the implementation of allow_commit.
| traceback_txt = buff.getvalue() | ||
| with StringIO() as buff: | ||
| traceback.print_exc(file=buff) | ||
| traceback_txt = buff.getvalue() |
Member
There was a problem hiding this comment.
I'm fine with the earlier reclamation of memory here; just calling it out since it is not germaine to the primary intent of this pull request.
florentx
force-pushed
the
18.0-queue_job-savepoint
branch
from
October 21, 2026 19:58
6987195 to
39ed622
Compare
florentx
force-pushed
the
18.0-queue_job-savepoint
branch
from
October 21, 2026 20:02
39ed622 to
b64a51f
Compare
ivantodorovich
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a simplification.
This is needed for the change proposed in:
Changes:
job.perform()so that cursor can be re-used in case of OperationalError"queue.job"record-use the same cursor, which is in good shape thanks to the savepoint
allow_commit=Trueuse case)