Repository navigation
Document UDQ support in PYACTION - #40
Draft
panasun1994 wants to merge 1 commit into
Draft
panasun1994 wants to merge 1 commit into
panasun1994 wants to merge 1 commit into
Conversation
Contributor
Author
|
@SoilRos, this is the documentation for UDQ support. Please review it. |
SoilRos
reviewed
Oct 26, 2026
| ---------------------------------------------- | ||
|
|
||
| The ``UDQ`` keyword can be inserted from a PYACTION script. These features are supported | ||
| in both serial and parallel runs: |
Member
There was a problem hiding this comment.
Is there any difference between serial and parallel runs for pyaction? If not, I would exclude this sentence. If yes, we need to explain the difference.
| schedule = opm_embedded.current_schedule | ||
|
|
||
| # Run the insertion only once | ||
| if 'setup_done' not in globals(): |
Member
There was a problem hiding this comment.
What happens when the user has more than one pyaction? Is this variable shared among all python scripts or is there one for each one? If there is only one globally, we need to be careful to advertise this generic variable name as it would only be initialized by the first script.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After adding the valid keyword in PR#5500 and creating the test in PR#7581, here is the first documentation of UDQ support. Note that this documentation assumes that PR#7581, PR#5500, and PR#1673 have been merged into master. The links to
PYACTION_UDQ_INSERT_KW.DATA,pyaction_udq_insert_kw.pyandACTIONX_UDQ_INSERT_KW.DATAneed one more opm-tests PR, which I will open and link here.Another note: In the code block for Inserting UDQ keywords. the body of
ifis not related to the condition; this because the keywordASSIGN WU_X '?'is still not supported yet. So, I use a named well,ASSIGN WU_FLAG 'OP01' 5, instead.