Repository navigation
Replace hard-coded blues with design tokens - #3552
Conversation
Nav, top nav and search highlight backgrounds used the Octopus blue scale at low opacity rather than theme tokens. Point them at the colorMenuList* tokens, pair the active rows with colorMenuListTextPrimary, and merge the duplicate nav variables in main.css into vars.css. Also move tag chips, the search box and results, the post-meta border, the Link component and the blue status icons onto theme tokens, and remove the variables that are now unused. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Pull request environment is available at https://stoctodocspr3552.z22.web.core.windows.net/. You can view the ephemeral environment status in Octopus Deploy. This environment will be automatically deprovisioned when the pull request is closed, or after 7 days of inactivity. |
|
@enf0rc3 good callout on the claude review for all those other things that changed. My initial take was that these changes were intentional (from our design team) By one example, the left-nav active items have changed from a light blue to a lot more of a gray. I wonder though if it is. I'll ping Ellen for her thoughts. |
enf0rc3
left a comment
There was a problem hiding this comment.
Thanks for this, in some places its a big improvement in visibility.
I am happy with the change so approving, check the screenshots and if your happy, feel free to merge at your leisure (if you wanted to confirm with design etc)
The colorMenuListBackgroundHover token was too heavy for nav rows, so hover and active now share colorNavListBackgroundActive, with the active row set apart by textBodyBoldMedium instead. Active rows use colorTextPrimary rather than colorMenuListTextPrimary. Search results still need hover and keyboard-active to differ, so they move onto the colorMenuList* tokens directly rather than sharing the nav variables. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>










🤖 Claude Code wrote this:
Several parts of the site styled themselves with fixed blue colours, or with blue values from the design system's colour scales, rather than theme tokens. This moves them onto tokens that already exist in the published
@octopusdeploy/design-system-tokenspackage.Changes
colorNavListBackgroundActive. The current-page row is set apart bytextBodyBoldMediuminstead of a different background. Its text usescolorTextPrimary, which gives contrast of 12.5:1 in light and 11.0:1 in dark.colorMenuListBackgroundHover/colorMenuListBackgroundActivedirectly rather than the nav variables.main.css(--navBackground*) are merged into the--colorNav*ones invars.css.colorChipBackgroundPrimary/colorChipTextPrimaryreplace a translucent light blue.--body-link-alt):colorTextPrimaryreplaces blue-grey in light and white in dark.colorTextField*tokens for the border, placeholder and icons;colorBorderPrimaryfor result borders;colorTextTertiaryfor result paths;colorOverlayPrimaryfor the overlay.colorBorderPrimary, theLinkcomponent usescolorTextLinkDefault/colorTextLinkHover, and the blue status icons usecolorIconInfo.Visible changes on the current theme
The search result hover keeps its existing blue tint for now. Its matching token (
colorSearchBackgroundResultHover) isn't present in the shipped version of the tokens package, it will come laterTesting
pnpm buildpasses (3,136 pages) and spellcheck passes on the changed files. The build hasn't been re-run since the nav follow-up commit, which only changes CSS.On the dev server, bolding the highlighted endpoint in the API nav doesn't make any label wrap onto an extra line, and the nav doesn't shift while scrolling (checked on
/docs/api/accountsat 1440px and wider).