Repository navigation
docs(openspec): propose the slender pass changes - #436
Merged
Merged
Conversation
4 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
The slender pass pull request (#435) was hard to review because the two OpenSpec changes behind it made up almost a thousand of its lines. They now live in this pull request, so the reviewer can read the plan here and the code in #435.
The two changes describe the feature from the player's side.
add-slender-passlets a player redeem a pass in the lobby to play the Slender in the next round, andadd-slender-pass-earningcovers how passes are earned by playing and through a monthly quota for ranks. Their task lists already show the state of the implementation in #435.Types of changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any ofthem, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.
Further comments
add-slender-pass-earningmodifies the spec thatadd-slender-passintroduces, soadd-slender-passhas to be archived first.