Repository navigation
docs(openspec): propose polish-plugin-messages - #17
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
The first test of Quelea 0.2.0 on the team proxy worked, but the messages look flat.
/partyshows a grey wall of text, commands cannot be clicked, and success, errors and hints look the same. Translations are fixed to English and German inside the jar, so even a colour tweak needs a release.This change proposes three things:
messages_<lang>.propertiesfiles intoplugins/quelea/lang/to add a language or override single messages. Missing or broken keys fall back to English.Redirecting chat into the party with
@or a toggle is deliberately left out. It needs SignedVelocity on the proxies plus a Minestom backend part, and gets its own change.Types of changes
Checklist
Further comments
Ships as
feat(velocity): give party messages colour, clickable help and open translations. Adventure'sGlobalTranslatorwas considered and rejected in the design.