Repository navigation
feat(velocity): give party messages colour, clickable help and open translations - #18
Merged
Merged
Conversation
Contributor
Test results102 files 102 suites 1m 3s ⏱️ Results for commit fdf50da. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
The first real test of Quelea on the team proxy worked end to end: create, invite, a click on [Accept], and following the leader into Bounce. But the messages felt flat.
/partyprinted a grey wall of text, nothing could be clicked, success and failure looked alike, and several actions answered twice ("Party created." plus "TheMeinerLP created the party.", or "You joined the party." two times).Now every message follows one palette: the brand gradient for the prefix and headers, green for success, red for problems, amber for hints, and a gold ★ for the leader. Each
/partyhelp line can be clicked, which puts the command into the chat input, and hovering explains it. [Accept] and [Deny] explain themselves on hover. Party chat has its own coloured line.The player who runs a command reads only the command's answer. The event that follows notifies the other members, not the actor again. This covers create, accept, deny, leave, kick, promote, and a disband by the leader. Clicking an old [Accept] after joining now says "You are already in this party." instead of "no pending invites".
Translations are no longer locked in the jar. The plugin chooses the bundle by client language and country (
de_AT→de→en). Operators can dropmessages_<tag>.propertiesintoplugins/quelea/lang/in the proxy template to add a language or recolour a single message. Missing keys and templates that fail to parse fall back to English, with one log line.Implements the OpenSpec change
polish-plugin-messages.Types of changes
Checklist
Further comments
Plugin only: 117 tests green (
./gradlew :velocity:test). The.selfvariants of joined, denied and left were dropped because the actor no longer receives those events. A disband caused by the last member leaving still tells the leaver that the party ended, which is intended. Redirecting normal chat into the party with@is out of scope and needs SignedVelocity plus a Minestom backend part.