Repository navigation
docs(openspec): propose follow-leader-to-lobby - #19
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
On the team proxy, following the leader into a game worked: the leader went from
Lobby-2toBounce-1, and the member followed within a second. Coming back did not. After the leader's/lobby, the member stayed in the finished round, and after typing/lobbythemselves landed onLobby-1while the leader was onLobby-2. The party fell apart exactly when players expect it to stay together.This proposes one rule for every move of the leader: a member follows if they were on the server the leader just left, or if they are idle in a lobby. A member in another game stays. That covers the round ending (game → lobby), today's case (lobby → game), and keeping the party in one lobby instance. To know where the leader came from, warps carry an optional origin (
fromServerin the request,fromin the event). Old plugins ignore it.Types of changes
Checklist
Further comments
Ships as
feat(party): bring the party back to the lobby with its leader. Rejected alternatives (tracking members' servers in the service, warping only on game → lobby) are recorded in the design. Party-aware lobby selection at login belongs to Titan and is out of scope.