Repository navigation
test(persistence): skip container tests on runners without docker - #37
Merged
Merged
Conversation
The macOS and Windows CI runners have no Docker, so every Testcontainers class failed there with initializationError. Linux still runs them.
Contributor
Test results 180 files 180 suites 2m 8s ⏱️ Results for commit cdbe95b. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Every pull request showed red builds on macOS and Windows. No code was broken. GitHub's macOS and Windows runners have no Docker, so each Testcontainers class failed with
initializationErrorbefore running a single test. That buried any real failure on those platforms under the same red mark.The four Postgres test classes now use
@Testcontainers(disabledWithoutDocker = true). Where Docker is missing they are skipped, and everything else still builds and runs. The Linux runner and local machines with Docker run them exactly as before. Locally:adapters/persistence30 tests andverification9 tests, none skipped.Type of change
Checklist
./gradlew build testpasses locally (:adapters:persistence:test :verification:test)