[YellowNest]

Summary

Release the MSAA dynamic-annotation servers owned by settings trees before their hosting DLL can be unloaded.

Root cause

The accessibility changes from #2518 register CSettingsTreeAccServer instances with IAccPropServices::SetHwndPropServer.

Those registrations are not currently cleared when the settings dialogs are destroyed. After Open-Shell exits, StartMenuDLL can therefore be unloaded while oleacc still retains marshaled references to a CSettingsTreeAccServer.

The dump in #2556 shows the later cleanup path trying to dispatch CSettingsTreeAccServer::Release() through the old StartMenuDLL address, which matches that lifetime mismatch.

Changes

• add a full settings-tree accessibility cleanup helper
• clear per-item state/name/role annotations while tree item accessibility IDs are still valid
• clear the tree-level container annotation and accessible name
• run the full cleanup from both settings-tree destroy paths while the child HWNDs still exist
• keep the existing item-only cleanup used when a tree is rebuilt during normal dialog operation

This does not change accessibility behavior while a settings dialog is alive; it only closes the lifetime of the dynamic annotations explicitly before teardown.

Validation

• based on current master
• single focused commit
• reviewed against the Explorer crashes during SetControlAccessibleName #2556 dump and the registrations introduced in Improve screen reader, keyboard, and High Contrast accessibility #2518
• runtime reproduction to verify: repeatedly Exit Open-Shell, wait, then reopen Open-Shell Menu Settings

Fixes #2556

[ge0rdi]

I've tested with this build and I cannot reproduce any crash anymore.
👍

[YellowNest]

Great, thanks for testing. The build is green as well, so I've marked this ready for review.