Repository navigation
Conversation
The Ford download branch wrote decrypted container bytes and a SHA-1 to stdout. Those lines interleave with an embedding app's stdout protocol and expose decrypted payload. Remove both debug prints; the payload is still decoded and the Ford key map is unchanged.
Author
|
Local verification passed: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_mmcswrote decrypted Ford container bytes and a SHA-1 to stdout. In an embedding process that reserves stdout for a line protocol, those writes appear as foreign output and expose decrypted payload. Remove both debug prints; the Ford payload is still decoded and the key map is unchanged.Context
The branch runs when an MMCS
AuthorizeGetResponsecarries aford_reference; it is shared by attachment, shared-stream and CloudKit downloads.Verification
cargo build --release --features 'macos-validation-data,remote-clearadi' --package rustpush --libpasses locally on Linux.\n-git diff --checkpasses.\n- GitHub Actions Build is awaiting maintainer approval for this fork PR; GitGuardian passes.