Repository navigation
chore: sync template dead-code tags and test fixes - #147
Merged
Merged
Conversation
Propagate SceneryStackTemplate fd8e10f: tag template toolkit exports @public for dead-code checkers, make the flat-button aliases distinct objects, call document.hasFocus() in the fuzz liveness probe, and document the detached getContext in tests/setup.ts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Propagates SceneryStackTemplate fd8e10f to this sim's template-owned files.
tests/helpers/memoryLeak.ts,src/common/<Sim>ButtonOptions.ts,src/common/<Sim>ControlOptions.ts: tag the template's toolkit exports@public. Each sim uses only some of them, so dead-code checkers (knip) reported the rest as unused in every sim. Sim-added exports are left untagged.FLAT_RECTANGULAR_BUTTON_OPTIONSandFLAT_RESET_ALL_BUTTON_OPTIONSbecome their own objects instead of aliases (knip reported duplicate exports). Same option values.tests/fuzz/fuzz.spec.ts: the liveness probe now callsdocument.hasFocus()instead of returning the unbound method.tests/setup.ts: document whygetContextis stored detached.Comments and tags only, apart from the two option objects and the fuzz probe. Verified lint and typecheck on QuantumPotential, FluidPressureAndFlow, MotionSensor and ACPhasor.
🤖 Generated with Claude Code