Repository navigation
Fix freezes in the New Printer wizard - #489
Open
SinghCod3r wants to merge 3 commits into
Open
SinghCod3r wants to merge 3 commits into
SinghCod3r wants to merge 3 commits into
Conversation
Run the check on the worker and show one centered spinner while waiting.
Create the queue on the worker. Apply is disabled while it runs.
Remove the failed driverless entry so the Makes list falls back to Generic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I click Forward or Apply in the New Printer wizard, the window sometimes freezes for a second or two. The cursor shows busy, nothing else happens, and then the next page appears. This PR fixes that.
I measured the click path and found two slow calls on the GTK thread:
What changed:
In this SMB is not touched, and I reused the existing worker and spinner code instead of adding new frameworks.
How I tested: