Repository navigation
[backport] Serialize the filehash DoS tests - #2465
Merged
Merged
Conversation
test_probes_filehash_dos.sh and test_probes_filehash58_dos.sh both create and remove /tmp/oscap-test-fifo and /tmp/oscap-test-symlink, the paths their OVAL definitions name. Under ctest -j, when both run, one removes the files the other is about to read, or fails to create a file the other just made. A RESOURCE_LOCK on both runs them one at a time. The filehash test exists only with OPENSCAP_ENABLE_SHA1 and OPENSCAP_ENABLE_MD5 on, both off by default. Built with both on, 50 runs of ctest -j2 over the two tests on Fedora 44 failed twice on main, each time in test_probes_filehash58_dos.sh 0.3 seconds in. With this change the 50 runs passed.
|
matusmarhefka
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a backport of the PR #2456 to the maint-1.3 branch.
test_probes_filehash_dos.sh and test_probes_filehash58_dos.sh both create and remove /tmp/oscap-test-fifo and /tmp/oscap-test-symlink, the paths their OVAL definitions name. Under ctest -j, when both run, one removes the files the other is about to read, or fails to create a file the other just made. A RESOURCE_LOCK on both runs them one at a time. The filehash test exists only with OPENSCAP_ENABLE_SHA1 and OPENSCAP_ENABLE_MD5 on, both off by default.
Built with both on, 50 runs of ctest -j2 over the two tests on Fedora 44 failed twice on main, each time in test_probes_filehash58_dos.sh 0.3 seconds in. With this change the 50 runs passed.