Repository navigation
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Offer registered aliases in morph-map keys and polymorphic query type arrays, including named arguments and long array syntax. Also complete config keys in array writes. Reuse the shared lexical scan to distinguish keys, values and argument positions without scanning the file again. Exclude arrow-function bodies and unrelated parameters while preserving existing resource completion. Add unit regressions for unfinished arrays, comments, Unicode identifiers and existing string contexts.
Exercise morph-map keys and all polymorphic query methods through the completion handler, including named arguments and imported aliases. Verify prefix filtering, text edits and rejection of unrelated positions. Cover config writes with both array syntaxes and ensure config values and later arguments do not receive key suggestions.
Add playground examples for morph-map keys, polymorphic query types and config array keys. Verify map registration and query alias behavior with Laravel runtime assertions. Describe the feature in the changelog and remove the completed backlog entry from both todo documents.
shuvroroy
force-pushed
the
feat/laravel-morph-alias-array-completion
branch
from
October 12, 2026 04:37
2bc09a6 to
894d76a
Compare
shuvroroy
marked this pull request as ready for review
October 12, 2026 04:40
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Registered morph aliases now complete in morph-map array keys and the types passed to polymorphic relationship queries such as
whereHasMorph(). Config keys also complete in array writes.The shared lexical scan identifies the argument and array position, including named arguments and unfinished source. Tests cover short and long arrays, prefix edits, comments, and positions that must not receive these suggestions. Laravel playground examples and runtime assertions demonstrate the feature.
Validation
Validated with Rust 1.99:
cargo +1.99 test— full suite passed.cargo +1.99 clippy --fix --allow-dirty -- -D warningscargo +1.99 clippy --all-targets -- -D warningscargo +1.99 fmtandcargo +1.99 fmt --checkChecklist
CHANGELOG.mdREADME.md,docs/,examples/)config-schema.json) — not applicable