Repository navigation
Conversation
Offer known model columns in attribute-array keys, preferring fillable attributes and skipping keys already present in the same literal. Extend scalar column arguments and installed model PHP attributes. Resolve inherited columns and accessors through the shared type engine. Parse the enclosing call for exact argument roles and reuse the lexical scanner for comments, documents, and unfinished arrays. Exclude relation properties and guarded wildcards from column candidates.
Exercise model, builder, and relationship receivers through the public completion handler, including named arguments, sibling keys, incomplete arrays, scalar operators, and version-gated model PHP attributes. Verify replacement ranges and correct the shared cursor helper to count UTF-16 units consistently with LSP positions.
Add attribute-array and scalar-column completion examples, a model PHP attribute example, and runtime assertions for their Laravel behavior. Describe the feature in the changelog and remove the completed backlog entry from both todo documents.
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
shuvroroy
marked this pull request as ready for review
October 12, 2026 05:12
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eloquent attribute-array keys now suggest the model's known columns. In calls such as
User::create(['name' => $name, '…' => $value]), fillable attributes appear first andnameis omitted from the remaining suggestions. Both arrays in lookup-or-create calls use the same completion.Column completion also covers
firstWhere(), both column operands ofwhereColumn(), aggregates, and the column-name PHP attributes available in the installed Laravel version. It follows model, builder, and relationship receivers through the shared type engine, including inherited columns and accessors. Values, operators, nested arrays, relation properties, and the guarded wildcard do not receive attribute suggestions.Validation
Validated with Rust 1.99:
cargo +1.99 test— full suite passed.cargo +1.99 llvm-cov test— full instrumented suite passed; all 408 changed instrumented source lines are covered locally.cargo +1.99 clippy --fix --allow-dirty -- -D warningscargo +1.99 clippy --all-targets -- -D warningscargo +1.99 fmtandcargo +1.99 fmt --checkapp/Demo.phplines 777 and 988.Checklist
CHANGELOG.mdREADME.md,docs/,examples/)config-schema.json) — not applicable