Repository navigation
Conversation
Expand plural resource and singleton registrations through the shared route collector so route completion, diagnostics, hover, definitions, and parameter completion see their generated names and URIs. Apply literal registration options and fluent modifiers in Laravel's order, including singleton creation/deletion and API filter overrides. Preserve empty resource segments and empty name-prefix overrides rather than normalizing them into different routes. Reuse scalar truthiness for shallow routing and borrow repeated URI fragments to avoid unnecessary copies. Add scanner regressions for degenerate names, option precedence, naming replacement, and literal shallow flags.
Exercise plural and singleton registrations through editor handlers, checking completion and unknown-route diagnostics against the same expected names. Cover grouped routes, custom names and parameters, API action filtering, shallow singleton behavior, degenerate resource names, and navigation to each individual registration literal, including UTF-16 source positions.
Add working plural-resource and singleton routes, a stateless demo controller, editor examples, and runtime assertions against Laravel. Document the feature in the changelog and remove the completed backlog item. Record the existing renamed-Route-import discovery gap as a separate follow-up rather than extending this change into facade name resolution.
shuvroroy
marked this pull request as ready for review
October 13, 2026 16:30
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Route names generated by plural resource registrations and singleton controllers now work in completion, diagnostics, hover, go-to-definition, and route-parameter completion. For example,
Route::resources(['photos' => PhotoController::class])makesphotos.showavailable, whileRoute::singleton('profile', ProfileController::class)generates routes without a profile ID parameter.The shared scanner applies literal options and fluent modifiers in Laravel's order, including API filtering and singleton creation/deletion. Empty names, trailing slashes, and empty dot-separated segments retain Laravel's actual route names and URIs. This implements L44.
Validation:
cargo +1.99 test: 16,998 passed, 14 ignored.-D warningsand formatting checks passed.The existing route-discovery gap for renamed facade imports was recorded separately as L61 in the backlog.
Checklist
CHANGELOG.mdREADME.md,docs/,examples/)how it works, how it's organized), including any code drafted by an LLM.
an eye towards deleting anything that is irrelevant, clarifying anything
that is confusing, and adding details that are relevant. This includes,
for example, commit descriptions, PR descriptions, and code comments.
No config schema changes are needed.