Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 2 of #1040. Builds on #1046: only the last five commits are new here. I'll rebase once #1046 is merged.
Summary
The plugin that owns a virtual container registers a handler for its type.
/co rollbackand/co restorewithcontainer:hand the changes to that handler instead of touching an inventory themselves.registerVirtualContainer(Plugin, NamespacedKey, VirtualContainerHandler)andVirtualContainerHandler#apply(String id, List<VirtualContainerChange> changes).VirtualContainerChangehasgetItem(),isAddition()(the direction is already resolved for rollback vs restore) andgetSlot()(the slot recorded by Add virtual containers: log and look up plugin-owned inventories (part 1 of #1040) #1046, or -1).beginMutation/endMutation, pending futures, item counts). If two operations hit the same container at once, the second is cancelled, as with entity tracking rows.r:, a world,#worldedit,#containeror#preview. A single container (container:<type>/<id>) can be rolled back withoutu:; a whole type still needsu:, like any globala:containerrollback.RollbackUpdateTargets.VIRTUAL_CONTAINER, Process 39 and the ClickHouse rollback family forvirtual_container. No schema change.docs/commands.mdanddocs/api/version/v13.md(handler contract and an example).Testing
u:; running the same command again changes nothing;u:is rejected, and works withu:;co_virtual_container;container:accepted and rejected by rollback and restore.Merge risk
Additive on top of #1046. Existing rollbacks change in one place only: item rows of virtual containers, which only
container:selects, are taken out before the update queues.A handler that breaks the contract (applies part of a change, then throws) can duplicate or lose items in its own container; the docs spell the contract out. As with regular container rollbacks, a second rollback of the same container started before the consumer commits the first one's marks would apply again.