Repository navigation
Change message when unable to load manifest to warning - #1772
Open
Steve Lee (SteveL-MSFT) wants to merge 3 commits into
Open
Steve Lee (SteveL-MSFT) wants to merge 3 commits into
Steve Lee (SteveL-MSFT) wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused logging change matches the reported issue, preserves discovery behavior, and updates the corresponding test assertions.
No open issues 🎉
What changed in this PR
This PR addresses #1765 by making resource manifest load failures visible at warning level while preserving nonfatal resource discovery behavior.
Changes:
- Raise manifest load failure logging from
infotowarnand update the accompanying comment. - Update both existing discovery test assertions to expect
WARN.
| File | Description |
|---|---|
| lib/dsc-lib/src/discovery/command_discovery.rs | Log manifest load failures as warnings. |
| dsc/tests/dsc_discovery.tests.ps1 | Expect warning-level diagnostics in existing tests. |
Review effort: Balanced
Steve Lee (SteveL-MSFT)
requested a review
from Mikey Lombardi (He/Him) (michaeltlombardi)
October 23, 2026 13:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Change message when a manifest fails to load from
info(not displayed by default) towarnto make it more obviousPR Context
Fix #1765