This repository was archived by the owner on Oct 19, 2026. It is now read-only.
Repository navigation
camera_still: take the shutter from boot_button - #16
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Board configs now expose the BOOT button only as
boot_button, a raw input, never as a key inkeypad(PyDevices/pydevices#164). Socamera_still.pywraps it inGPIOButtonsitself and registers it withapp.add_keypad. BOOT still arrives as an ordinary KEYDOWN, and the file still doesn't know which GPIO the button is on.Checked on an ESP32-P4-WIFI6-DEV-KIT with the KeDei 5" panel and the updated board configs: the live view starts, the keypad device is registered from
boot_button(reading released), and the shutter path saves a JPEG. A physical press of BOOT wasn't run.