Skip to content

ci(lint): forbid empty catch blocks in lib/features without logIgnored #1763

Closed

Description

@ZhuchkaTriplesix

Problem

Nothing stops a new `catch (_) {}` in the UI layer, so the silent failures audited in the sibling issue come back. The repo already has guard tests (for example the shadcn imports ratchet).

Proposal

A guard test (or analyzer rule) over `lib/features` and `lib/shared`: a `catch` block must not be empty; it must call `logIgnored`, the reporting helper, rethrow or handle the error. Start as a ratchet with the current count so existing sites do not block merges, and lower it as the audit proceeds.

Also worth a look in the same pass: the 301 `unawaited(...)` calls; an exception there reaches only `runZonedGuarded` and `debugPrint`.

Part of the error-handling epic.

Activity

  1. added
    enhancementNew feature or request
    error-handlingTheme parser epic label: error-handling
    testsTheme parser epic
    P3Low priority / Polish & Enhancements
    on Oct 25, 2026
  2. added a commit that references this issue on Oct 25, 2026
  3. ZhuchkaTriplesix commented on Oct 25, 2026

    @ZhuchkaTriplesix
    MemberAuthor

    Fixed on dev in #1801 (merged). Closing by hand: the PRs target dev, so GitHub would only close this when dev is merged into main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P3Low priority / Polish & EnhancementsenhancementNew feature or requesterror-handlingTheme parser epic label: error-handlingtestsTheme parser epic

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions