Skip to content

fix(macos): connections were not saved: secrets go to the login keychain #1756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ZhuchkaTriplesix wants to merge 1 commit into from
Closed

fix(macos): connections were not saved: secrets go to the login keychain #1756

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions lib/core/storage/connection_secrets_store.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,17 @@ abstract class SecretsStorageBackend {
}

class _FlutterSecureStorageBackend implements SecretsStorageBackend {
<<<<<<< Updated upstream
final FlutterSecureStorage _storage = const FlutterSecureStorage(
mOptions: ConnectionSecretsStore.macOsOptions,
=======
/// macOS uses the login keychain: the plugin's default data-protection
/// keychain needs a `keychain-access-groups` entitlement, which the
/// Developer ID build does not carry, so every write failed with -34018 and
/// the new connection was rolled back.
final FlutterSecureStorage _storage = const FlutterSecureStorage(
mOptions: MacOsOptions(usesDataProtectionKeychain: false),
>>>>>>> Stashed changes
);

@override
Expand Down
Loading