Repository navigation
fix: review follow-ups (log rotation failure, folder load logging, closed tab after confirm) - #1796
Merged
Merged
Conversation
…ad failures are logged, a closed tab does not run a confirmed query
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From a read-only review of what was merged in the last session.
QueryaLog: a failed rotation (a rotated file open elsewhere, wrong permissions) used to fail every later write for the rest of the session, because_sizewas never reset. It is now caught: the log keeps writing to the current file and retries after anothermaxBytes. Test added.FoldersStorage.loadand the legacyfolders.jsonmigration write their failure to the log, not only the console.ssl_certificate_support: the 'cannot tell whether the process is alive' fallback is logged.generic_sql_workspace:if (!mounted) returnafter the settings read and the destructive dialog, before the buffer is dropped andsetStateruns.Not run locally, CI will.