Skip to content

Polish gh-152 #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MadSchemas merged 1 commit into from
Oct 27, 2026
Merged

Polish gh-152 #155

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 9 additions & 14 deletions src/main/java/ru/rt/restream/reindexer/ReindexerNamespace.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@
import ru.rt.restream.reindexer.util.BeanPropertyUtils;

import java.util.ArrayList;
import java.util.Collection;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
Expand Down Expand Up @@ -248,11 +247,16 @@ void registerPrecept(ReindexerPrecept precept) {

PreceptExpression[] getPrecepts(Object item, int format) {
Predicate<ReindexerPrecept> isNullPredicate = getIsNullPredicate(item, format);
List<PreceptExpression> precepts = new ArrayList<>();
for (ReindexerPrecept precept : getPrecepts()) {
applyPrecept(precept, isNullPredicate, precepts);
List<PreceptExpression> result = new ArrayList<>();
lock.readLock().lock();
try {
for (ReindexerPrecept precept : precepts.values()) {
applyPrecept(precept, isNullPredicate, result);
}
} finally {
lock.readLock().unlock();
}
return precepts.toArray(new PreceptExpression[0]);
return result.toArray(new PreceptExpression[0]);
}

private Predicate<ReindexerPrecept> getIsNullPredicate(Object item, int format) {
Expand All @@ -267,15 +271,6 @@ private Predicate<ReindexerPrecept> getIsNullPredicate(Object item, int format)
return it -> BeanPropertyUtils.getProperty(item, it.getFieldPath()) == null;
}

private Collection<ReindexerPrecept> getPrecepts() {
lock.readLock().lock();
try {
return precepts.values();
} finally {
lock.readLock().unlock();
}
}

private void applyPrecept(ReindexerPrecept precept, Predicate<ReindexerPrecept> isNullPredicate,
List<PreceptExpression> precepts) {
// Apply precept according to the strategy.
Expand Down
Loading