Repository navigation
Windows fix: Set window title on WM_NCCREATE - #355
Merged
Merged
Conversation
prokopyl
force-pushed
the
win-fix-window-title
branch
from
October 22, 2026 04:00
8f1ce47 to
019b22b
Compare
Member
|
Ah, yes that's a good catch! Thank you for the fix 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a regression from 0.3->0.4, introduced here. By handling WM_NCCREATE, we're no longer falling back to the default which sets up the non-client area, and as a result we are no longer displaying the window title in its usual position.
With this PR, we allow the control to pass back to the default handling.