Repository navigation
Light and overlay fixes — second try [develop] - #933
Open
PetrilloAtWork wants to merge 167 commits into
Open
PetrilloAtWork wants to merge 167 commits into
PetrilloAtWork wants to merge 167 commits into
Conversation
…plate It used to end when the template SPR goes under 1e-4 ADC#. Now it needs to stay within +/- 1w-4 ADC# for 20 nanoseconds. This should make it possible to include undershootings. All these parameters are currently hard-coded.
…icles that might cross cathode
Good catches on names and strings. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
- replaced explicit link to DetectorClocksServiceStandard with lardata::DetectorClocksService - removed redundant and unnecessary art framework libraries from link lists - fixed some documentation typos
…ples It allows the creation of a raw::trigger data product with the shifted time reference, which AdjustSimForTrigger module used not to produce (newer one does).
By default changes are applied to all gate types (used to be to unknown only). In addition, maintenance changes: - added debug messages; - moved some of the code of general use to `icarusalg` (sbn::BeamTime enumerator and selector); would be more impressive if the selector mechanism supported `fhicl::Sequence`, which it does not because support of `fhicl::Atom` was enough of a hack already.
This module allows to print explicitly which data product is picked when an input tag is specified at a certain step of the execution chain. For example, it would expand a `std::vector<sim::SimPhotons>` tag "shifted" to `shifted::DetSim`, or claim no data product matches.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Co-authored-by: mvicenzi <64699641+mvicenzi@users.noreply.github.com> Co-authored-by: Gianluca Petrillo <petrillo.at.work@gmail.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Gianluca Petrillo <petrillo@slac.stanford.edu>
Co-authored-by: Gianluca Petrillo <petrillo@slac.stanford.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a reprise of PR #922, created rebasing commit e17d5cd to the current
developbranch.Unit tests have been run to verify the formal correctness of the FHiCL configurations and some more tests, however there has not been any physics revalidation.
P.S. I added a "fix" for the FHiCL unit test which failed in
develop.