Repository navigation
fix(scanner): preserve option values - #125
Open
John-David Dalton (jdalton) wants to merge 1 commit into
Open
John-David Dalton (jdalton) wants to merge 1 commit into
John-David Dalton (jdalton) wants to merge 1 commit into
Conversation
John-David Dalton (jdalton)
deployed
to
socket-firewall
October 11, 2026 21:37 — with
GitHub Actions
Active
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LLM Description written by CODEX:GPT-6
Summary
Preserve commas in Socket Tier 1 additional parameter values while retaining the legacy comma separator before a new option. Document the supported repeated
--exclude-pathsform for Tier 1 scans.Changes
Testing
/private/tmp/basics-ce83-venv/bin/python -m pytest tests/test_socket_tier1_additional_params.py(11 passed)git diff --checkpassed.This verifies argument parsing only; no end-to-end scan omission or published image behavior was tested.
Note
Medium Risk
Parsing behavior for existing
SOCKET_ADDITIONAL_PARAMSstrings changes (mostly fixes comma-in-value cases); misconfigured quotes now error instead of running with wrong CLI args passed tosocket scan reach.Overview
Socket Tier 1
socket_additional_params/SOCKET_ADDITIONAL_PARAMSparsing no longer splits on every comma. A new tokenizer keeps commas inside option values (including quoted values) and still treats an unquoted comma before another-flag as the legacy separator, then runsshlexsplitting. Malformed quoting now fails fast withConnectorExecutionErrorinstead of silently mis-splitting args.Docs and GitHub Action / connector descriptions are aligned: space-separated options, repeat list flags like
--exclude-paths, and examples for excluding Tier 1 scan paths via CLI, env, or Action input. Regression tests cover repeated flags, comma-in-values, legacy--view=full,--all, escapes, and bad quotes.Reviewed by Cursor Bugbot for commit bf09322. Configure here.