Repository navigation
Full storage navigation fix - #246
Merged
Merged
Conversation
…what is being shown Prompt: When we look at a root storage only the folder pane container is being shown, this should only happen on the soloPane scenario for non root resources. Co-authored-by: Claude Opus 5.5 <claudeopus5.5-opus@openai.com>
…@5.0.2-3) (latest: rdflib@2.4.1)
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The localized changes preserve legacy defaults, consistently apply the new view modes, and have no identified blocking issues.
No open issues 🎉
What changed in this PR
This PR adds explicit folder view modes to support full storage navigation while preserving existing solo and fullView behavior.
Changes:
- Adds
explorer,storage, andcontainermodes, with explicit selections taking precedence over legacy options. - Allows storage mode to hide the storage header while retaining the sidebar and content.
- Adds view-selection tests and bumps the package version to
4.0.1-1.
| File | Description |
|---|---|
| test/folderView.test.js | Tests explicit view selection and legacy defaults. |
| src/folderPane.ts | Resolves view modes and applies component options. |
| src/components/folder-pane-view/FolderPaneView.ts | Makes the storage header optional. |
| package.json | Updates the package version. |
| package-lock.json | Synchronizes the lockfile version metadata. |
Review effort: Balanced
timea-solid
approved these changes
Oct 25, 2026
timea-solid
left a comment
timea-solid
left a comment
Member
There was a problem hiding this comment.
am excited to see a fix for this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix navigation as the full storage view was not displaying on the storage containers.