Repository navigation
Browse.html was not acting like it was logged in when it was - #247
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Rate-limit cooldowns can be bypassed, and generation changes can leave folder details permanently unresolved.
3 open issues
What changed in this PR
This PR addresses access-denied errors during authenticated folder browsing and reduces background requests for folder details.
Changes:
- Retry access-denied resource loads with a fresh fetcher entry when logged in.
- Load visible items’ counts and access indicators through a concurrency-limited queue with rate-limit backoff.
- Add tests for queue scheduling, retries, clearing, and Retry-After parsing.
| File | Description |
|---|---|
test/requestQueue.test.js |
Tests queue behavior and rate-limit handling. |
src/requestQueue.ts |
Adds request concurrency limits, retries, and clearing. |
src/components/folder-pane-view/FolderPaneView.ts |
Retries authenticated resource loads after access-denied errors. |
src/components/folder-pane-container/FolderPaneContainer.ts |
Queues visible-item details and manages observation lifecycle. |
Review effort: Balanced
SharonStrats
force-pushed
the
fix-browsehtml
branch
from
October 25, 2026 06:55
c50f16b to
6a6261d
Compare
timea-solid
approved these changes
Oct 25, 2026
SharonStrats
force-pushed
the
fix-browsehtml
branch
from
October 25, 2026 20:32
6a6261d to
486bb7e
Compare
SharonStrats
force-pushed
the
fix-browsehtml
branch
from
October 25, 2026 21:47
d7f9c89 to
77bd39f
Compare
Prompt: When a user is logged in they should be able to see their resources and not get an access denied message. Co-authored-by: GPT-5.6 Luna <gpt-5.6-luna@openai.com>
SharonStrats
force-pushed
the
fix-browsehtml
branch
from
October 25, 2026 22:59
70f4b6e to
3051dc6
Compare
…@5.0.2-3) (latest: rdflib@2.4.1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When logged in and navigating storage I received an access denied errors on all my resources.