Skip to content

change the loading to be lazier, also recognized contents was not sho… - #250

Draft
SharonStrats wants to merge 1 commit into
stagingfrom
fix/loading-plus-contents
Draft

SharonStrats wants to merge 1 commit into
stagingfrom
fix/loading-plus-contents

Conversation

@SharonStrats

@SharonStrats SharonStrats commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

This fixes an issue with the primary pane not showing in the drop down, it also fixes the contents menu item to now show the folder view.

It also changes the loading of the item count and the public/private.
So now this information only shows if a container has already been loaded and is in the store or once the user clicks on the 3 dot menu the contents load and the information will appear.

@timea-solid I'm wondering if this would be a good first fix for the release and then we can sort out the rest after?

@bourgeoa I'd just want to check with you that this prevents the 429 errors and 999.

Need to fix this as I fixed the contents and primary pane now in a different PR since it needed to be fixed no matter what.

@SharonStrats
SharonStrats requested a balanced review from Copilot October 26, 2026 05:47
@SharonStrats SharonStrats self-assigned this Oct 26, 2026
@SharonStrats SharonStrats added the bug Something isn't working label Oct 26, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Contents navigation can leave unloaded folders showing an empty listing, and failed pane discovery cannot be retried by reopening the menu.

2 open issues
What changed in this PR

This PR makes folder browsing lazier and adds explicit access to folder contents alongside recognized application panes.

Changes:

  • Load pane actions and access metadata when a resource’s menu is clicked.
  • Display member counts only when folder data is already loaded.
  • Add a Contents menu entry and folder-specific rendering paths.
File Description
src/​components/​folder-pane-view/​FolderPaneView.ts Adds folder-specific navigation and explorer options.
src/​components/​folder-pane-container/​FolderPaneContainer.ts Defers resource details and builds menus with preferred panes and Contents.

Review effort: Balanced

Comment thread src/components/folder-pane-container/FolderPaneContainer.ts Outdated
Comment thread src/components/folder-pane-view/FolderPaneView.ts Outdated
@SharonStrats
SharonStrats force-pushed the fix/loading-plus-contents branch from ba5a5d5 to 616fb60 Compare October 26, 2026 08:18
@SharonStrats

Copy link
Copy Markdown
Contributor Author

I have made some small changes in the fix for the 3dot menu issue i was having we will see if that helps first.

@SharonStrats
SharonStrats marked this pull request as draft October 27, 2026 08:56
@SharonStrats SharonStrats moved this to Backlog in SolidOS NLNet UI Oct 27, 2026
@timea-solid

Copy link
Copy Markdown
Member

I'll.l test it on staging and than I'll know more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

3 participants