Repository navigation
change the loading to be lazier, also recognized contents was not sho… - #250
Draft
SharonStrats wants to merge 1 commit into
Draft
SharonStrats wants to merge 1 commit into
SharonStrats wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Contents navigation can leave unloaded folders showing an empty listing, and failed pane discovery cannot be retried by reopening the menu.
2 open issues
What changed in this PR
This PR makes folder browsing lazier and adds explicit access to folder contents alongside recognized application panes.
Changes:
- Load pane actions and access metadata when a resource’s menu is clicked.
- Display member counts only when folder data is already loaded.
- Add a Contents menu entry and folder-specific rendering paths.
| File | Description |
|---|---|
src/components/folder-pane-view/FolderPaneView.ts |
Adds folder-specific navigation and explorer options. |
src/components/folder-pane-container/FolderPaneContainer.ts |
Defers resource details and builds menus with preferred panes and Contents. |
Review effort: Balanced
…wing folder view and pane wasn't in menu
SharonStrats
force-pushed
the
fix/loading-plus-contents
branch
from
October 26, 2026 08:18
ba5a5d5 to
616fb60
Compare
Contributor
Author
|
I have made some small changes in the fix for the 3dot menu issue i was having we will see if that helps first. |
SharonStrats
marked this pull request as draft
October 27, 2026 08:56
timea-solid
approved these changes
Oct 27, 2026
Member
|
I'll.l test it on staging and than I'll know more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This fixes an issue with the primary pane not showing in the drop down, it also fixes the contents menu item to now show the folder view.
It also changes the loading of the item count and the public/private.
So now this information only shows if a container has already been loaded and is in the store or once the user clicks on the 3 dot menu the contents load and the information will appear.
@timea-solid I'm wondering if this would be a good first fix for the release and then we can sort out the rest after?
@bourgeoa I'd just want to check with you that this prevents the 429 errors and 999.
Need to fix this as I fixed the contents and primary pane now in a different PR since it needed to be fixed no matter what.