Repository navigation
add cached media type detection - #348
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Static review identified no blocking issues in these narrowly scoped changes; automated tests were not run.
No open issues 🎉
What changed in this PR
Adds cache-only media detection to the resource logic API, allowing consumers to identify images, audio, and video without fetching resources.
Changes:
- Adds media detection using RDF types and cached Content-Type headers.
- Exposes detection helpers through
ResourceLogicand adds focused tests. - Updates the package version to
6.0.1-5.
| File | Description |
|---|---|
test/resource/resourceLogic.test.ts |
Tests cached-header and RDF-type detection without web operations. |
src/types.ts |
Declares the new media detection methods. |
src/resource/resourceLogic.ts |
Implements generic media detection and image, audio, and video helpers. |
package.json |
Bumps the package version. |
package-lock.json |
Synchronizes the package version metadata. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the image and media checks for a resource to use in the slideshow