Repository navigation
Refreshing browse.html - do not redirect - #777
Merged
Merged
Conversation
SharonStrats
requested review from
bourgeoa and
timea-solid
and
a balanced review from Copilot
October 25, 2026 06:31
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
URL preservation also skips navigation metadata updates, leaving navigation listeners with stale pane and account-menu state.
1 open issue
What changed in this PR
Adds an opt-in URL-preservation option for standalone shells such as browse.html, allowing them to display a subject without replacing the shell’s address.
Changes:
- Adds
preserveUrlto navigation options. - Skips history updates when URL preservation is requested.
- Documents the option for standalone-shell callers.
| File | Description |
|---|---|
src/outline/manager.js |
Adds the history-update guard for URL preservation. |
src/navigation/options.ts |
Defines the optional preserveUrl flag. |
docs/navigation-design.md |
Documents shell usage and unchanged default behavior. |
Review effort: Balanced
SharonStrats
force-pushed
the
fix-browsehtml
branch
from
October 25, 2026 06:51
291a727 to
6401bb9
Compare
timea-solid
approved these changes
Oct 25, 2026
SharonStrats
force-pushed
the
fix/navigation-views
branch
from
October 25, 2026 20:04
477f95f to
5ac3124
Compare
SharonStrats
force-pushed
the
fix-browsehtml
branch
2 times, most recently
from
October 25, 2026 21:36
23faa32 to
c42b100
Compare
Prompt: when on browse.html the user gets redirected to localhost:3100/storare Co-authored-by: GPT-5.6 Luna <gpt-5.6-luna@openai.com>
SharonStrats
force-pushed
the
fix-browsehtml
branch
from
October 25, 2026 21:48
c42b100 to
d93f289
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix redirect for browse.html and also needed to make a couple other changes because the profile heading was not appearing when viewing a webid.