Repository navigation
fix slideshow render - #779
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Ordinary slideshow navigation removes the resource menu without replacement controls for switching panes or accessing resource actions.
1 open issue
What changed in this PR
This PR updates slideshow rendering and its integration with pane selection and navigation.
Changes:
- Recognizes images by content type, deduplicates and sorts resources, and initializes each slideshow independently.
- Moves slideshow registration ahead of folders and uses the shared preferred-pane selector.
- Hides slideshow headers in solo mode and updates navigation tests and pane-selection mocks.
| File | Description |
|---|---|
test/unit/outline/manager.test.ts |
Mocks the shared preferred-pane selector. |
test/unit/navigation/chrome.test.ts |
Tests slideshow header visibility in solo mode. |
src/slideshow/slideshowPane.js |
Updates image detection, ordering, and instance initialization. |
src/registerPanes.js |
Registers slideshow before the folder pane. |
src/outline/manager.js |
Uses shared pane selection and passes solo mode to header logic. |
src/navigation/chrome.ts |
Suppresses slideshow headers in solo mode. |
Review effort: Balanced
SharonStrats
force-pushed
the
slideshow
branch
from
October 26, 2026 00:47
58872c3 to
42e2c27
Compare
SharonStrats
force-pushed
the
slideshow
branch
from
October 26, 2026 10:47
cf89ae0 to
4e026d9
Compare
…@5.0.2-4 pane-registry@5.0.2-1 folder-pane@4.0.1-1 profile-pane@4.1.0-0 source-pane@4.0.1-0) (latest: rdflib@2.4.1 activitystreams-pane@2.0.0 chat-pane@4.0.0 contacts-pane@4.0.0 issue-pane@4.0.0 meeting-pane@4.0.0)
…@5.0.2-4 pane-registry@5.0.2-1 folder-pane@4.0.1-1 profile-pane@4.1.0-0 source-pane@4.0.1-0) (latest: rdflib@2.4.1 activitystreams-pane@2.0.0 chat-pane@4.0.0 contacts-pane@4.0.0 issue-pane@4.0.0 meeting-pane@4.0.0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Slideshow was not showing because it is a bit different than other panes it shows when there is a container with more than one image. It also appeared after the folder pane in the register pane list so it was rendering the folder view instead.
Code improvements were made as well to use solid logic where possible instead of recreating the same functions.
A few slideshow improvements.