Skip to content

fix slideshow render - #779

Merged
SharonStrats merged 3 commits into
stagingfrom
slideshow
Oct 26, 2026
Merged

SharonStrats merged 3 commits into
stagingfrom
slideshow

Conversation

@SharonStrats

@SharonStrats SharonStrats commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Slideshow was not showing because it is a bit different than other panes it shows when there is a container with more than one image. It also appeared after the folder pane in the register pane list so it was rendering the folder view instead.

Code improvements were made as well to use solid logic where possible instead of recreating the same functions.

A few slideshow improvements.

  • Added image detection based on both RDF metadata and HTTP Content-Type headers, allowing image containers to be recognized more reliably.
  • Added deterministic image ordering by resource URI.
  • Added duplicate-image filtering so the same resource is only displayed once.
  • Added unique slideshow IDs so multiple slideshow instances do not conflict.
  • Added authenticated image loading through the Solid store fetcher.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Ordinary slideshow navigation removes the resource menu without replacement controls for switching panes or accessing resource actions.

1 open issue
What changed in this PR

This PR updates slideshow rendering and its integration with pane selection and navigation.

Changes:

  • Recognizes images by content type, deduplicates and sorts resources, and initializes each slideshow independently.
  • Moves slideshow registration ahead of folders and uses the shared preferred-pane selector.
  • Hides slideshow headers in solo mode and updates navigation tests and pane-selection mocks.
File Description
test/​unit/​outline/​manager.test.ts Mocks the shared preferred-pane selector.
test/​unit/​navigation/​chrome.test.ts Tests slideshow header visibility in solo mode.
src/​slideshow/​slideshowPane.js Updates image detection, ordering, and instance initialization.
src/​registerPanes.js Registers slideshow before the folder pane.
src/​outline/​manager.js Uses shared pane selection and passes solo mode to header logic.
src/​navigation/​chrome.ts Suppresses slideshow headers in solo mode.

Review effort: Balanced

Comment thread src/navigation/chrome.ts Outdated
…@5.0.2-4 pane-registry@5.0.2-1 folder-pane@4.0.1-1 profile-pane@4.1.0-0 source-pane@4.0.1-0) (latest: rdflib@2.4.1 activitystreams-pane@2.0.0 chat-pane@4.0.0 contacts-pane@4.0.0 issue-pane@4.0.0 meeting-pane@4.0.0)
…@5.0.2-4 pane-registry@5.0.2-1 folder-pane@4.0.1-1 profile-pane@4.1.0-0 source-pane@4.0.1-0) (latest: rdflib@2.4.1 activitystreams-pane@2.0.0 chat-pane@4.0.0 contacts-pane@4.0.0 issue-pane@4.0.0 meeting-pane@4.0.0)
@SharonStrats SharonStrats linked an issue Oct 26, 2026 that may be closed by this pull request
@SharonStrats
SharonStrats merged commit f044bcc into staging Oct 26, 2026
8 checks passed
@SharonStrats
SharonStrats deleted the slideshow branch October 26, 2026 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

slideshow doesn't not work

2 participants