Repository navigation
move preferred pane function to be used by solid panes and folder pane - #912
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The exact root-export assertion omits the newly exported helper and will fail until its expected list is updated.
1 open issue
What changed in this PR
Adds a shared preferred-pane helper for use by Solid panes and the folder pane.
Changes:
- Selects a pane by mint class, then focus request, then registry order.
- Adds unit tests for selection precedence.
- Bumps the package version to
5.0.2-4.
| File | Description |
|---|---|
| test/unit/file-explorer/relevant-panes.test.ts | Tests preferred-pane selection and fallbacks. |
| src/lib/file-explorer/relevant-panes.ts | Exports the shared getPreferredPane helper. |
| package.json | Updates the package version. |
| package-lock.json | Synchronizes the lockfile version. |
Review effort: Balanced
SharonStrats
force-pushed
the
add-preferred-pane
branch
from
October 26, 2026 00:12
e961f6a to
79e8fec
Compare
…istry@5.0.2-1) (latest: rdflib@2.4.1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.