Repository navigation
fix view not showing new content when switching from source to view - #234
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Delayed saves can overwrite another resource’s content, and refresh failures interrupt successful-save finalization.
2 open issues
What changed in this PR
This PR addresses stale content when switching from source editing to the rendered view by updating shared content and reloading the saved resource.
Changes:
- Adds a shared-context callback to update the saved source content.
- Forces a resource refresh after a successful save.
- Adds generation checks to ignore outdated content-load results.
| File | Description |
|---|---|
| src/primitives/context.ts | Adds the content-update callback to the context interface. |
| src/components/source-provider/SourceProvider.ts | Exposes content updates and guards against outdated loads. |
| src/components/source-editor-card/SourceEditorCard.ts | Updates shared content and refreshes the resource after saving. |
Review effort: Balanced
SharonStrats
force-pushed
the
fix/refresh
branch
from
October 27, 2026 10:12
56c7605 to
60bb5d6
Compare
…istry@5.0.2-1 solid-ui@5.0.2-4) (latest: rdflib@2.4.1)
SharonStrats
enabled auto-merge
October 27, 2026 10:15
timea-solid
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes problem with refresh