Repository navigation
Fix write_BIDS_probe crash when device_channel_indices are set - #474
Open
aaronkanzer wants to merge 1 commit into
Open
aaronkanzer wants to merge 1 commit into
aaronkanzer wants to merge 1 commit into
Conversation
alejoe91
approved these changes
Oct 26, 2026
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
write_BIDS_probefails on any probe that has wiring with more than one channel:Observed:
Expected: the files are written, and
read_BIDS_probe("out").probes[0].device_channel_indicesreturns[3 2 1 0].Cause: the writer checks
if probe.device_channel_indices:, but that attribute is a numpy array or None. Only unwired probes and single-contact probes could be written.Fix: check
is not Noneinstead. The reader already restores thedevice_channel_indicescolumn throughProbe.from_dataframe, so the round trip works once the writer stops crashing. Adds a round-trip test with a wired probe.