Repository navigation
Conversation
…nto compare-analyzers-alessio
alejoe91
marked this pull request as ready for review
October 27, 2026 14:21
alejoe91
requested review from
chrishalcrow and
samuelgarcia
and removed request for
chrishalcrow
October 27, 2026 14:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements a
ComparisonControllerand several views to facilitate the comparison and inspection of the output of two spike sorters.It implements a new
run_mainwindow_comparisonfunction:And a bunch of comparison views, with a
comparisonpreset:CompareUnitListView: core of the comparison, display pairs of matched units + unmatched units by sorters, ordered by agreementVennView: Venn diagram with units in agreement, with a slider to change the agreement thredhold. Clicking on regions randomly select units from that region (match, sorter1 only, sorter2 only)AgreementMatrixView: same as similarity view, but displaying agreement. Selecting a unit on the diagonal will select the corresponding row in theCompareUnitListView. Off-diagonal clicks (e.g. to check oversplits) will select units in the "classic"UnitListView" (by default same zone asCompareUnitListView`)CompareSpikeListView: venn diagram at the spike level, for unit pairs. It also shows sample waveforms from the different groups (match, sorter1 only, sorter2 only) when thewaveformsextension is available (no recompute)CompareMetricsView: shows scatters of selected metrics, only for paired units above the match threshold defined in theVennViewReady to review on my end!
Docs are updated and tested both desktop and web modes!
Screencast.from.2026-10-27.15-19-01.webm