Repository navigation
Remove BaseSnippets class - #4839
Merged
Merged
Conversation
alejoe91
marked this pull request as ready for review
October 14, 2026 12:46
Member
Author
|
@chrishalcrow this should be ready. I added the change in #4896 |
chrishalcrow
approved these changes
Oct 27, 2026
chrishalcrow
left a comment
chrishalcrow
left a comment
Member
There was a problem hiding this comment.
Read through the code and checked the PR locally for any missed "snippet"s - can't find any. Confident that tests would raise any issues with the refactoring of core. - all looks good!
alejoe91
commented
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
BaseSnippetsis unused and over-complicates the code base. Since it's not a common use case anymore (and it should not be) let's remove that concept.