Skip to content

fix(backend): delete registration answers of removed participants - #359

Merged
marftn merged 4 commits into
mainfrom
fix/deleted-participant-answers
Oct 19, 2026
Merged

marftn merged 4 commits into
mainfrom
fix/deleted-participant-answers

Conversation

@marftn

@marftn marftn commented Oct 16, 2026

Copy link
Copy Markdown
Contributor

Changes

  • When a participant is removed from a hackathon, their registration answers for this hackathon's question are deleted as well.
  • The necessary db migration code has been added.

This closes #347

@marftn
marftn requested a review from sabinem October 16, 2026 14:08

@sabinem sabinem left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marftn : Good work on the answer removal part. I added just one comment on changing the sequence on db change and role change.

I a follow up PR or in this PR we should also consider other items that might be left hanging, such as team participation and preferences, not sure what else. I think we need a detailed list on what should go with the participation and what can stay. It probably also depends on the stage: so if the participant already submitted then maybe removal should not be possible any more. I will write a ticket for that.

Comment thread components/backend/internal/service/hackathon_service.go
@marftn
marftn force-pushed the fix/deleted-participant-answers branch from 61351c5 to 48a4006 Compare October 16, 2026 17:31
@marftn

marftn commented Oct 16, 2026

Copy link
Copy Markdown
Contributor Author

Thanks @sabinem! I moved the RemoveRole line as suggested.

@marftn
marftn requested a review from sabinem October 16, 2026 17:34

@sabinem sabinem left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marftn Looks good to me now. I approved it.

@marftn marftn changed the title fix: delete registration answers of removed participants fix(backend): delete registration answers of removed participants Oct 19, 2026
@marftn
marftn merged commit 598cd16 into main Oct 19, 2026
3 checks passed
@marftn
marftn deleted the fix/deleted-participant-answers branch October 19, 2026 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

backend: delete registration answers when a participant is removed from a hackaton

2 participants