Repository navigation
fix(teams): opaque save bar clear of the nav - #360
Merged
Merged
Conversation
The Manage Teams save bar is sticky but its background is the translucent warning tint, so teams scrolling underneath showed through it, and it sat flush against the nav bar. Stick it inside a canvas-filled wrapper with 2px of top padding: the content underneath is hidden, the gap below the nav is solid rather than a see-through slit, and the tint still renders over the page colour, so it matches the unsaved cards. The height measurement moves to the wrapper so the sticky search row still lines up below.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Manage Teams save bar is sticky but its background is the translucent warning tint, so teams scrolling underneath showed through it.
Stick it inside a canvas-filled wrapper with 2px of top padding: the content underneath is hidden, the gap below the nav is solid rather than a see-through slit, and the tint still renders over the page colour, so it matches the unsaved cards. The height measurement moves to the wrapper so the sticky search row still lines up below.