Repository navigation
fix(voting): one final vote per category, and block over-budget ballots - #366
Merged
Merged
Conversation
Single choice could be changed but points could not: the backend keeps an existing points vote and silently ignores a resubmit. Rather than a different rule per method, every category now takes one vote, final once submitted; a voted category shows what was cast instead of the ballot. - A points ballot over its budget cannot be submitted, and says how many points to take back (per-field max never caught a total spread across several entries). - A refused vote's reason shows next to that ballot's button, not at the top of the page. - Point fields drop leading zeros on change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR simplifies the participants voting:
Before: Single choice could be changed but points could not: the backend keeps an existing points vote and silently ignores a resubmit.
Now: Rather than a different rule per method, every category now takes one vote, final once submitted; a voted category shows what was cast instead of the ballot.
Details: