Repository navigation
fix(settings): let the Themes list scroll and take keyboard focus - #3456
Merged
Merged
Conversation
1 of 27 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The Themes list in Settings > Appearance did not scroll, and clicking a theme did not give the list keyboard focus, so the arrow keys did nothing. The list sat inside the pane's grouped Form. Measured on macOS 27: SwiftUI turns scrolling off for a
Listnested in a scrolling grouped Form (no scroller, no elasticity, a scroll event does not move it), and its rows do not take focus. The fixed 176 pt height then cut off every theme past the first few.Change
Verified
AppearancePaneListTests(the list moves on a scroll event) and the newAppearanceSettingsUITests.testThemesListScrollsAndTakesArrowKeys(scroll to the last theme, click, Down Arrow moves the selection) fail on main and pass here. The existing Appearance flow passes; it no longer scrolls the Form to reach the list's buttons.Screenshots
Not in this PR
MCPTokenListView), License devices and team, Loadable Extensions in the connection form.