Repository navigation
Conversation
Editing a parent tag from the tag editor only redrew the parent list, so categories inherited through that parent's own parents stayed stale until the original tag was changed. Refresh the category section as well. Fixes TagStudioDev#1551. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1551.
When a parent tag is edited from the tag editor, the nested modal's save callback only redrew the parent list (
_set_parent_tags). The categories section is derived from the parents' hierarchy, so adding or removing a parent's own parents left the original tag's category exclusions stale until something else triggered_set_categories.Parent rows now use
_on_parent_tag_edited, which refreshes both the parent list and the categories. Category rows already pass_set_categories, so they're unchanged.Two regression tests open the parent's edit modal through the capsule's
on_editsignal, change that parent's parents, and emitsaved. One checks that a newly inherited category appears, the other that a removed one disappears. Both fail onmainand pass with this change.Tasks Completed
pytest(317 passed, Python 3.14,QT_QPA_PLATFORM=offscreen)ruff format --checkandruff checkpyrighton the changed files (0 errors)I verified this through pytest-qt rather than clicking through the GUI by hand.
🤖 Generated with Claude Code