Skip to content

fix(notification): ensure notifications are dismissed correctly by id - #5965

Open
romainseb wants to merge 1 commit into
masterfrom
oly/fix/notification-not-disapearing
Open

romainseb wants to merge 1 commit into
masterfrom
oly/fix/notification-not-disapearing

Conversation

@romainseb

@romainseb romainseb commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

What is the problem this PR is trying to solve?
Green notification are not disappearing anymore

What is the chosen solution to this problem?
Fix it

Please check if the PR fulfills these requirements

  • The PR have used pnpm changeset to a request a release from the CI if wanted.
  • The PR commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features) And non reg done before need review
  • Docs have been added / updated (for bug fixes / features)
  • Related design / discussions / pages (not in jira), if any, are all linked or available in the PR

[ ] This PR introduces a breaking change

@changeset-bot

changeset-bot Bot commented Oct 30, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 6197197

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@talend/react-containers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@romainseb
romainseb deployed to pull_request_unsafe October 30, 2026 15:28 — with GitHub Actions Active
@romainseb
romainseb deployed to pull_request_unsafe October 30, 2026 15:28 — with GitHub Actions Active
@romainseb
romainseb deployed to pull_request_unsafe October 30, 2026 15:28 — with GitHub Actions Active
@romainseb
romainseb deployed to pull_request_unsafe October 30, 2026 15:28 — with GitHub Actions Active
@github-actions

Copy link
Copy Markdown
Contributor

Storybook for this PR deployed on this github page

@github-actions

Copy link
Copy Markdown
Contributor
Title Lines Statements Branches Functions
cmf Coverage: 89%
89.53% (1275/1424) 83.99% (656/781) 89.92% (357/397)
cmf-cqrs Coverage: 87%
86.77% (164/189) 71.59% (63/88) 83.05% (49/59)
cmf-router Coverage: 95%
95.31% (224/235) 91.27% (157/172) 90.56% (48/53)
components Coverage: 90%
90.81% (5604/6171) 82.57% (3250/3936) 88.26% (1407/1594)
containers Coverage: 84%
83.55% (1407/1684) 75.85% (732/965) 75.28% (332/441)
dataviz Coverage: 86%
85.93% (330/384) 65.41% (157/240) 75.94% (120/158)
design-system Coverage: 68%
67.92% (1101/1621) 54.06% (612/1132) 55.71% (239/429)
faceted-search Coverage: 85%
85.33% (640/750) 80.82% (295/365) 82.24% (227/276)
flow-designer Coverage: 75%
74.89% (692/924) 77.69% (418/538) 72.88% (207/284)
forms Coverage: 87%
87.03% (1698/1951) 78.08% (987/1264) 85.45% (470/550)
http Coverage: 97%
98.01% (99/101) 95.52% (64/67) 100% (36/36)
sagas Coverage: 92%
92.3% (24/26) 66.66% (4/6) 50% (2/4)
stepper Coverage: 81%
82.29% (158/192) 61.05% (58/95) 82% (41/50)
utils Coverage: 98%
98.9% (90/91) 90% (18/20) 100% (29/29)

Comment thread package.json
"vitest:update": "cross-env TZ=UTC pnpm -r --if-present --workspace-concurrency=1 run vitest:update",
"storybook:build": "turbo run storybook:build",
"storybook:start": "pnpm --filter @talend/ui-storybook-one run start",
"storybook:start": "pnpm --filter @talend/scripts-config-storybook-lib run build:lib && pnpm --filter @talend/ui-storybook-one run start",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please revert this change

This branch was successfully deployed

1 active deployment
pull_request_unsafe — 61971978 Deployed Oct 30, 2026 by romainseb via Build and test #8648
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants