Skip to content

Added area algorithms - #15590

Closed
nibblus wants to merge 10 commits into
TheAlgorithms:masterfrom
nibblus:math_area_improvements
Closed

Added area algorithms#15590
nibblus wants to merge 10 commits into
TheAlgorithms:masterfrom
nibblus:math_area_improvements

Conversation

@nibblus

@nibblus nibblus commented Oct 17, 2026

Copy link
Copy Markdown

Describe your change

  • Add an algorithm?
    to math/area
  • lateral_surface_area_hemisphere(): calculate lateral surface area of a hemisphere
  • lateral_surface_area_conical_frustum(): calculate lateral surface area of conical frustrum
  • area_triangle_side_angle_side(): calculate area when 2 sides and angle are given
  • area_triangle_angle_side_angle(): calculate area when 2 angles and side are given
  • Fix a bug or typo in an existing algorithm?
  • Changed instances of "1/2 * formula" into "formula / 2" as it is more accurate in edga case of floating point precision
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?
  • fixed a few typos,
  • added formulas, add wikipedia references

Checklist

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues, then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@nibblus
Added algorithm:
9db2ab1 
 - lateral_surface_area_hemisphere(): calculate lateral surface area of a hemisphere
 - lateral_surface_area_conical_frustum(): calculate lateral surface area of conical frustrum
 - area_triangle_side_angle_side(): calculate area when 2 sides and angle are given
 - area_triangle_angle_side_angle(): calculate area when 2 angles and side are given

 Fixes:
 - Changed instances of "1/2 * formula" into "formula / 2"  as it is more accurate in edga case of floating point precision

 Documentation changes:
 - fixed a few typos,
 - added formulas, add wikipedia references
@algorithms-keeper algorithms-keeper Bot added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files tests are failing Do not merge until tests pass labels Oct 17, 2026
@algorithms-keeper algorithms-keeper Bot removed the tests are failing Do not merge until tests pass label Oct 17, 2026
@nibblus
Less inaccurate implementation of Taylor series.
d2dd189 
Clearer way to limit angle between -360 and 360 using modulo
Avoid recalculating factorial(x) every iteration.
Keep calculating until next term has no longer effect on the result.
All existing doctests still succeed.
@nibblus nibblus changed the title Added algorithm: Added area algorithms Oct 17, 2026
@nibblus

nibblus commented Oct 17, 2026

Copy link
Copy Markdown
Author

I messed up pull requests....

@nibblus nibblus closed this Oct 17, 2026
@nibblus
nibblus deleted the math_area_improvements branch October 17, 2026 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@nibblus